Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Fix num_gpus=1 for new API stack. #44664

Merged

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Apr 11, 2024

Fix num_gpus=1 for new API stack.

  • Currently (since this PR here 5 days ago), the option to run with exactly 1 GPU (num_learner_workers=1) is broken.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@can-anyscale
Copy link
Collaborator

Feel free to just merge into the master branch :D. The current 2.11 release branch will be refresh with a new base/commit of master this weekend (check #release-management for more details).

Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sven1977 sven1977 merged commit 13f065b into ray-project:master Apr 11, 2024
5 checks passed
@sven1977 sven1977 deleted the fix_num_gpus_1_for_new_api_stack branch April 11, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants