-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RLlib] Cleanup examples folder 06: custom_gym_env
example script translated to new API stack + util function cleanup
#44707
Merged
sven1977
merged 9 commits into
ray-project:master
from
sven1977:cleanup_examples_folder_06_custom_gym_env
Apr 14, 2024
Merged
[RLlib] Cleanup examples folder 06: custom_gym_env
example script translated to new API stack + util function cleanup
#44707
sven1977
merged 9 commits into
ray-project:master
from
sven1977:cleanup_examples_folder_06_custom_gym_env
Apr 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sven1977 <[email protected]>
…nup_examples_folder_04
Signed-off-by: sven1977 <[email protected]>
…nup_examples_folder_04
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
sven1977
requested review from
avnishn,
ArturNiederfahrenhorst,
maxpumperla,
kouroshHakha and
simonsays1980
as code owners
April 12, 2024 15:26
sven1977
added
rllib
RLlib related issues
rllib-docs-or-examples
Issues related to RLlib documentation or rllib/examples
rllib-newstack
rllib-oldstack-cleanup
Issues related to cleaning up classes, utilities on the old API stack
labels
Apr 12, 2024
simonsays1980
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@@ -1,141 +1,235 @@ | |||
# TODO (sven): Move this example script into the new API stack. | |||
|
|||
"""Example of using an env-task curriculum via implementing a custom callback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this build upon the example cleanup folder 04? I just have a dejavu :)
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rllib
RLlib related issues
rllib-docs-or-examples
Issues related to RLlib documentation or rllib/examples
rllib-newstack
rllib-oldstack-cleanup
Issues related to cleaning up classes, utilities on the old API stack
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup examples folder 06:
custom_gym_env
example script translated to new API stackrun_rllib_example_script_experiment
.Why are these changes needed?
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.