[RLlib] Cleanup examples folder 07: Translate custom_experiment, custom_logger, custom_progress_reporter to new API stack.
#44735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sven1977 <[email protected]>
…nup_examples_folder_04
Signed-off-by: sven1977 <[email protected]>
…nup_examples_folder_04
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
…nup_examples_folder_07_custom_experiment_logger_trainfn Signed-off-by: sven1977 <[email protected]> # Conflicts: # rllib/examples/checkpoints/checkpoint_by_custom_criteria.py # rllib/examples/curriculum/curriculum_learning.py
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
…nup_examples_folder_07_custom_experiment_logger_trainfn
sven1977
requested review from
avnishn,
ArturNiederfahrenhorst,
maxpumperla,
kouroshHakha and
simonsays1980
as code owners
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
simonsays1980
approved these changes
Apr 16, 2024
| | 71.7485 | 100000 | 476.51 | 476.51 | | ||
| +------------------+--------+----------+--------------------+ | ||
|
|
||
| When running without parallel evaluation (`--evaluation-not-parallel-to-training` flag), |
There was a problem hiding this comment.
Yeah this is really cool! Parallel to training
| # TODO (sven): Find out why we require this hack. | ||
| import os | ||
|
|
||
| os.environ["RAY_AIR_NEW_OUTPUT"] = "0" |
There was a problem hiding this comment.
I guess it would help users, if we describe in one line why we set this env variable.
There was a problem hiding this comment.
We do this in the line above:
# Force Tuner to use old progress output as the new one silently ignores our custom
# `CLIReporter`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup examples folder 07: Translate
custom_experiment,custom_logger,custom_progress_reporterto new API stack.Plus:
restore()call on the local EnvRunner (and all remote EnvRunners) are wrong.Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.