Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] PyFlyt QuadX WayPoints #44758

Merged
merged 19 commits into from
Jun 6, 2024
Merged

[RLlib] PyFlyt QuadX WayPoints #44758

merged 19 commits into from
Jun 6, 2024

Conversation

peterghaddad
Copy link
Contributor

@peterghaddad peterghaddad commented Apr 16, 2024 •
edited
Loading

Why are these changes needed?

An example to leverage the PyFlyt environment with RLlib enabling users to train drones in the PyBullet physics engine.

Related issue number

Closes #44738

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@anyscalesam anyscalesam added triage Needs triage (eg: priority, bug/not-bug, and owning component) rllib RLlib related issues labels Apr 29, 2024
@anyscalesam
Copy link
Contributor

@sven1977 @simonsays1980 can you take a look please?

@simonsays1980 simonsays1980 self-assigned this May 7, 2024
@simonsays1980 simonsays1980 added enhancement Request for new feature and/or capability rllib-docs-or-examples Issues related to RLlib documentation or rllib/examples rllib-newstack P2 Important issue, but not time-critical and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels May 7, 2024
simonsays1980
simonsays1980 requested changes May 14, 2024
View reviewed changes
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome PR - the example is very nice! CHanges requested concern mainly our move from the old to the new stack. @peterghaddad if you need help somewhere or want me to adapt the code, ping me please.

We appreciate your work @peterghaddad ! This is really a nice example I have not thought about before. Hope to see more from you in the future!

rllib/examples/envs/classes/pyflyt_quadx_waypoints_env.py Outdated Show resolved Hide resolved
rllib/examples/quadx_waypoints.py Outdated Show resolved Hide resolved
rllib/examples/quadx_waypoints.py Outdated Show resolved Hide resolved
rllib/examples/quadx_waypoints.py Show resolved Hide resolved
rllib/examples/quadx_waypoints.py Outdated Show resolved Hide resolved
@peterghaddad
Copy link
Contributor Author

@simonsays1980 addressed feedback! Let me know if there is anymore feedback!

@simonsays1980
Copy link
Collaborator

@simonsays1980 addressed feedback! Let me know if there is anymore feedback!

@peterghaddad Thanks for the comments! So, for the error occuring in the new stack we need to dig into this deeper. I have a guess, where this is rooted. I come back to you when I know more.

@peterghaddad
Copy link
Contributor Author

@simonsays1980 addressed feedback! Let me know if there is anymore feedback!

@peterghaddad Thanks for the comments! So, for the error occuring in the new stack we need to dig into this deeper. I have a guess, where this is rooted. I come back to you when I know more.

@simonsays1980 Appreciate you diving in! From a quality and training perspective, I think this example is good to go. LSTM isn't necessary for us to move forward; however, i'm glad we are finding things that can be fixed!

@simonsays1980 simonsays1980 mentioned this pull request May 21, 2024
Merged
8 tasks
@peterghaddad
Copy link
Contributor Author

@simonsays1980 are we good to move forward here? Also, thanks for diving into the fix use_lstm

simonsays1980
simonsays1980 requested changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Needs to pull the newest master with a fix for LSTM. Needs a cleanup before or after merge to include RLlib test utils.

rllib/examples/quadx_waypoints.py Show resolved Hide resolved
rllib/examples/quadx_waypoints.py Outdated Show resolved Hide resolved
rllib/examples/quadx_waypoints.py Show resolved Hide resolved
rllib/examples/quadx_waypoints.py Outdated Show resolved Hide resolved
@peterghaddad
Copy link
Contributor Author

Included RLLib test utils!

simonsays1980
simonsays1980 approved these changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Awesome PR !

@peterghaddad
Copy link
Contributor Author

@simonsays1980 thanks for approving! Still seeing the same error with lstm. Let's create another issue and address that there since the agent is converges without lstm. Once you reapprove, will you also be the one to merge it in? Thanks again for all the review!

sven1977
sven1977 approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sven1977 sven1977 enabled auto-merge (squash) June 6, 2024 10:26
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Jun 6, 2024
@sven1977
Copy link
Contributor

sven1977 commented Jun 6, 2024

All good to go. Sorry @peterghaddad for the many delays! Will auto-merge this once all tests pass ...

@sven1977 sven1977 merged commit 82e634d into ray-project:master Jun 6, 2024
8 checks passed
richardsliu pushed a commit to richardsliu/ray that referenced this pull request Jun 12, 2024
@peterghaddad @richardsliu
[RLlib] PyFlyt QuadX WayPoints (ray-project#44758)
1179e26 
Signed-off-by: Richard Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sven1977 sven1977 sven1977 approved these changes

@simonsays1980 simonsays1980 simonsays1980 approved these changes

@avnishn avnishn Awaiting requested review from avnishn

@ArturNiederfahrenhorst ArturNiederfahrenhorst Awaiting requested review from ArturNiederfahrenhorst

@maxpumperla maxpumperla Awaiting requested review from maxpumperla

@kouroshHakha kouroshHakha Awaiting requested review from kouroshHakha

Assignees

@simonsays1980 simonsays1980

Labels
enhancement Request for new feature and/or capability go add ONLY when ready to merge, run all tests P2 Important issue, but not time-critical rllib RLlib related issues rllib-docs-or-examples Issues related to RLlib documentation or rllib/examples rllib-newstack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RLlib] Add PyFlyte Example Using Gymnasium and Ray Tune
4 participants
@peterghaddad @anyscalesam @simonsays1980 @sven1977