[Tune] Remove trial table when running Ray Train in a Jupyter notebook #44858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hongpeng Guo <[email protected]>
Signed-off-by: Hongpeng Guo <[email protected]>
hongpeng-guo
requested review from
matthewdeng,
justinvyu and
woshiyyya
as code owners
hongpeng-guo
changed the title
justinvyu
reviewed
Apr 19, 2024
python/ray/tune/progress_reporter.py
Outdated
| @@ -1520,7 +1520,8 @@ def _detect_reporter(**kwargs) -> TuneReporterBase: | |||
|
|
|||
| Keyword arguments are passed on to the reporter class. | |||
| """ | |||
| if IS_NOTEBOOK: | |||
| _trainer_api = kwargs.pop("_trainer_api", False) | |||
There was a problem hiding this comment.
We can add _trainer_api as a keyword argument separate from kwargs.
There was a problem hiding this comment.
Just added a keyword arg _trainer_api for the function _detect_reporter().
Comment on lines
+804
to
+806
| trainer_reporter = _detect_reporter(_trainer_api=True) | ||
| self.assertFalse(isinstance(trainer_reporter, JupyterNotebookReporter)) | ||
| self.assertTrue(isinstance(trainer_reporter, CLIReporter)) |
Signed-off-by: Hongpeng Guo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR removes the trial table mistakenly displayed during Ray Train in a Jupyter notebook, which should only appear in Ray Tune sessions.
Related issue number
Closes #44776
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.