Fix incorrect use of ssh port forward option. #44973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abizjakpro
requested review from
ericl,
architkulkarni,
hongchaodeng and
a team
as code owners
This fixes the order of ports, making the port option (-p) of "ray dashboard" command actually work. Signed-off-by: Ambroz Bizjak <[email protected]>
rynewang
reviewed
Apr 26, 2024
| @@ -349,7 +349,7 @@ def run( | |||
| cf.bold(local), | |||
There was a problem hiding this comment.
is this log also the other way around?
There was a problem hiding this comment.
The log is OK, just the actual command is the wrong way. It only worked if the ports were the same.
There was a problem hiding this comment.
I think the confusion is from localhost which actually means the remote host: https://unix.stackexchange.com/questions/115897/whats-ssh-port-forwarding-and-whats-the-difference-between-ssh-local-and-remot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the order of ports, making the port option (-p) of "ray dashboard" command actually work.
If you cannot merge this as-is, feel free to make the trivial change yourself.