Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] - Adding missing __init__.py in 'algorithms/sac/torch' that was throwing an error. #45070

Merged

Conversation

simonsays1980
Copy link
Collaborator

@simonsays1980 simonsays1980 commented May 1, 2024

Why are these changes needed?

This is a bug fix for a MISSING __init__.py.

Related issue number

Closes #44954

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

…g an error when loading the 'SACConfig'.

Signed-off-by: Simon Zehnder <[email protected]>
@simonsays1980 simonsays1980 self-assigned this May 1, 2024
@simonsays1980 simonsays1980 added rllib-newstack rllib RLlib related issues labels May 2, 2024
Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix @simonsays1980 :)

@sven1977 sven1977 marked this pull request as ready for review May 2, 2024 10:01
@sven1977 sven1977 merged commit 0e5cfaf into ray-project:master May 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rllib RLlib related issues rllib-newstack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RLlib] missing __init__ file
2 participants