Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Bumped default REPORTER_UPDATE_INTERVAL_MS to 5s #45193

Merged
merged 1 commit into from
May 8, 2024

Conversation

alexeykudinkin
Copy link
Contributor

Why are these changes needed?

To reduce the pressure induced by

  • Relatively high-frequency of node-stats updates originated from Reporter Agent
  • Using JSON instead of Proto for payloads encoding

Related issue number

While this change is not addressing #45191, it aims at reducing the pressure on the Dashboard Head process by reducing the frequency of updates

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@alexeykudinkin alexeykudinkin added the dashboard Issues specific to the Ray Dashboard label May 8, 2024
@hongchaodeng hongchaodeng added the core Issues that should be addressed in Ray Core label May 8, 2024
@jjyao jjyao merged commit 6a266db into ray-project:master May 8, 2024
5 checks passed
HenryZJY pushed a commit to HenryZJY/ray that referenced this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues that should be addressed in Ray Core dashboard Issues specific to the Ray Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants