-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Logs] Add runtime env started logs to job driver #45255
[Logs] Add runtime env started logs to job driver #45255
Conversation
Signed-off-by: Gene Su <[email protected]>
Signed-off-by: Gene Su <[email protected]>
Hm, I'm a bit concerned about multiple processes writing to the same file. Will that work? I see this SO thread that warns against it: https://stackoverflow.com/questions/15096090/python-separate-processes-logging-to-same-file |
I see, thanks Alan! Let me try to work around it. |
… also fix tests Signed-off-by: Gene Su <[email protected]>
Signed-off-by: Gene Su <[email protected]>
Signed-off-by: Gene Su <[email protected]>
Signed-off-by: Gene Su <[email protected]>
Signed-off-by: Gene Su <[email protected]>
dashboard/modules/job/job_manager.py
Outdated
@@ -508,6 +525,9 @@ async def submit_job( | |||
self.event_logger.info( | |||
f"Started a ray job {submission_id}.", submission_id=submission_id | |||
) | |||
|
|||
driver_logger = self._get_job_driver_logger(submission_id) | |||
driver_logger.info("Runtime env setup is starting up") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's do.
"Runtime env is setting up."
I think by saying "is starting up", people may expect to see a "is completed" log message afterwards
Signed-off-by: Gene Su <[email protected]>
Why are these changes needed?
Added runtime env started logs to job driver
Related issue number
Closes https://github.com/anyscale/product/issues/27790
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.