Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up Serve proxy files #45486

Merged
merged 2 commits into from
May 22, 2024
Merged

Clean up Serve proxy files #45486

merged 2 commits into from
May 22, 2024

Conversation

KamenShah
Copy link
Contributor

@KamenShah KamenShah commented May 21, 2024 •
edited
Loading

This PR includes 2 changes:

  1. Cleaning up the proxy file to improve consistency for the HTTP and GRPC proxy.
  2. Add missing properties to testing classes to better simulate e2e tests.

@KamenShah
add changes
7b51a44 
Signed-off-by: Kamen Shah <[email protected]>
@KamenShah KamenShah changed the title Push trace changes upstream Push tracing changes upstream May 21, 2024
@KamenShah KamenShah changed the title Push tracing changes upstream Cleanup Proxy files and tests May 22, 2024
@KamenShah KamenShah changed the title Cleanup Proxy files and tests Cleanup Serve proxy files May 22, 2024
@KamenShah
remove unused field
068b06f 
Signed-off-by: Kamen Shah <[email protected]>
@KamenShah KamenShah requested a review from edoakes May 22, 2024 16:24
@KamenShah KamenShah changed the title Cleanup Serve proxy files Clean up Serve proxy files May 22, 2024
@edoakes edoakes enabled auto-merge (squash) May 22, 2024 18:04
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label May 22, 2024
@edoakes edoakes merged commit 7c2fdcf into ray-project:master May 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edoakes edoakes edoakes approved these changes

Assignees
No one assigned
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KamenShah @edoakes