Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Allow user to configure timeout for actor pool #45508

Merged
merged 4 commits into from
May 23, 2024

Conversation

bveeramani
Copy link
Member

Why are these changes needed?

If your Dataset waits more than 10 minutes to launch GPU actors, your program fails. This PR allows you to configure this behavior so that you can wait longer.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani bveeramani enabled auto-merge (squash) May 22, 2024 23:43
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label May 22, 2024
python/ray/data/context.py Outdated Show resolved Hide resolved
python/ray/data/context.py Outdated Show resolved Hide resolved
Signed-off-by: Balaji Veeramani <[email protected]>
@github-actions github-actions bot disabled auto-merge May 23, 2024 02:05
@bveeramani bveeramani enabled auto-merge (squash) May 23, 2024 02:18
Signed-off-by: Balaji Veeramani <[email protected]>
@github-actions github-actions bot disabled auto-merge May 23, 2024 04:13
@bveeramani bveeramani enabled auto-merge (squash) May 23, 2024 04:50
Signed-off-by: Balaji Veeramani <[email protected]>
@github-actions github-actions bot disabled auto-merge May 23, 2024 05:10
@bveeramani bveeramani merged commit d091bb5 into ray-project:master May 23, 2024
6 checks passed
@bveeramani bveeramani deleted the expose-actor-wait branch May 23, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants