Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rllib] - Example Cleanups new API Stack - Autoregressive Action Module #45525

Merged
merged 12 commits into from
May 24, 2024
Merged

[Rllib] - Example Cleanups new API Stack - Autoregressive Action Module #45525

merged 12 commits into from
May 24, 2024

Conversation

simonsays1980
Copy link
Collaborator

@simonsays1980 simonsays1980 commented May 23, 2024 •
edited
Loading

Why are these changes needed?

Implements an example of how to define an RLModule with dependent action distributions.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@simonsays1980
Changed comment.
c748df8 
Signed-off-by: Simon Zehnder <[email protected]>
@simonsays1980
Merge branch 'master' of https://github.com/ray-project/ray
6409007 
Signed-off-by: Simon Zehnder <[email protected]>
@simonsays1980
Merge branch 'master' of https://github.com/ray-project/ray
d2f9030 
Signed-off-by: Simon Zehnder <[email protected]>
@simonsays1980
Merge branch 'master' of https://github.com/ray-project/ray
a3416a8 
Signed-off-by: Simon Zehnder <[email protected]>
@simonsays1980
Merge branch 'master' of https://github.com/ray-project/ray
8582ad9 
Signed-off-by: Simon Zehnder <[email protected]>
@simonsays1980
Merge branch 'master' of https://github.com/ray-project/ray
b565f34 
Signed-off-by: Simon Zehnder <[email protected]>
@simonsays1980
Merge branch 'master' of https://github.com/ray-project/ray
c0eed1f 
Signed-off-by: Simon Zehnder <[email protected]>
@simonsays1980
Merge branch 'master' of https://github.com/ray-project/ray
341cb95 
Signed-off-by: Simon Zehnder <[email protected]>
@simonsays1980
Implemented Autoregressive Action RLModule with implementation. Still…
1287ec0 
… in testing.

Signed-off-by: Simon Zehnder <[email protected]>
@simonsays1980 simonsays1980 self-assigned this May 23, 2024
@simonsays1980 simonsays1980 added rllib RLlib related issues rllib-docs-or-examples Issues related to RLlib documentation or rllib/examples rllib-newstack labels May 23, 2024
@sven1977 sven1977 marked this pull request as ready for review May 23, 2024 18:59
@sven1977 sven1977 assigned sven1977 and unassigned simonsays1980 May 23, 2024
@simonsays1980
Implemented logic for inference (i.e. deterministic sampling), added …
e4fbfaf 
…docstrings and annotations and moved experiments to own file in parent folder. In addition fixed some minor bugs and tested the example script for bugs and learning.

Signed-off-by: Simon Zehnder <[email protected]>
@simonsays1980
Merge branch 'master' of https://github.com/ray-project/ray
b76807f 
Signed-off-by: Simon Zehnder <[email protected]>
@simonsays1980
Merge branch 'master' into example-autoregressive-action-dist
f363d42 
Signed-off-by: Simon Zehnder <[email protected]>
@sven1977 sven1977 enabled auto-merge (squash) May 24, 2024 14:13
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label May 24, 2024
sven1977
sven1977 reviewed May 24, 2024
View reviewed changes
rllib/examples/rl_modules/autoregressive_actions_rlm.py
@@ -0,0 +1,107 @@
"""An example script showing how to define and load an `RLModule` with
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice nice nice! Thanks for adding this.

sven1977
sven1977 approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could we add this script to the CI? New stack only. And some reachable learning criterium with the --as-test option.

@sven1977 sven1977 merged commit fde5203 into ray-project:master May 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sven1977 sven1977 sven1977 approved these changes

@ArturNiederfahrenhorst ArturNiederfahrenhorst Awaiting requested review from ArturNiederfahrenhorst

Assignees

@sven1977 sven1977

Labels
go add ONLY when ready to merge, run all tests rllib RLlib related issues rllib-docs-or-examples Issues related to RLlib documentation or rllib/examples rllib-newstack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonsays1980 @sven1977