Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data] Record more telemetry for newly added datasources #45647

Merged
merged 1 commit into from
May 31, 2024
Merged

[Data] Record more telemetry for newly added datasources #45647

merged 1 commit into from
May 31, 2024

Conversation

c21
Copy link
Contributor

@c21 c21 commented May 30, 2024

Why are these changes needed?

This PR is to add the telemetry recording for newly added datasources.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@c21 c21 added the go add ONLY when ready to merge, run all tests label May 31, 2024
@c21 c21 merged commit 3c9edf1 into ray-project:master May 31, 2024
6 checks passed
@c21 c21 deleted the update-tele branch May 31, 2024 20:43
richardsliu pushed a commit to richardsliu/ray that referenced this pull request Jun 12, 2024
@c21 @richardsliu
[Data] Record more telemetry for newly added datasources (ray-project…
19a1198 
…#45647)

This PR is to add the telemetry recording for newly added datasources.

Signed-off-by: Cheng Su <[email protected]>
Signed-off-by: Richard Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bveeramani bveeramani bveeramani approved these changes

@ericl ericl Awaiting requested review from ericl

@scv119 scv119 Awaiting requested review from scv119

@amogkam amogkam Awaiting requested review from amogkam

@scottjlee scottjlee Awaiting requested review from scottjlee scottjlee is a code owner

@raulchen raulchen Awaiting requested review from raulchen raulchen is a code owner

@stephanie-wang stephanie-wang Awaiting requested review from stephanie-wang stephanie-wang is a code owner

@omatthew98 omatthew98 Awaiting requested review from omatthew98 omatthew98 is a code owner

Assignees
No one assigned
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c21 @bveeramani