Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Improve fractional CPU/GPU formatting #45673

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

x13n
Copy link
Contributor

@x13n x13n commented Jun 2, 2024

Why are these changes needed?

This makes progress bar look nicer when fractional resources are used.

Related issue number

Closes #45610

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(
    • Manually verified commandline output

Signed-off-by: Daniel Kłobuszewski <[email protected]>
@raulchen raulchen enabled auto-merge (squash) June 2, 2024 22:48
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Jun 2, 2024
@raulchen raulchen merged commit 0e6864a into ray-project:master Jun 2, 2024
7 checks passed
@bveeramani
Copy link
Member

@x13n Nice! Thanks for the contribution!

richardsliu pushed a commit to richardsliu/ray that referenced this pull request Jun 12, 2024
This makes progress bar look nicer when fractional resources are used.

Signed-off-by: Daniel Kłobuszewski <[email protected]>
Signed-off-by: Richard Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Data] Weird rounding in progress bar when using partial CPUs
3 participants