Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Enhance env-rendering callback. #45682

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Jun 3, 2024

Enhance example env-rendering callback.

  • Allow passing in worker indices on which exclusively to render/log episodes.
  • Fix bug where for short rollout-fragment lengths, it could happen that the callback resets the best/worst stats after each sample() call (even those calls in which no episode is finished), thus messing up the best/worst stats and possibly logging/recording the wrong episodes.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: sven1977 <[email protected]>
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sven1977 sven1977 enabled auto-merge (squash) June 3, 2024 11:44
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Jun 3, 2024
@sven1977 sven1977 disabled auto-merge June 3, 2024 13:18
@sven1977 sven1977 merged commit e6e21ac into ray-project:master Jun 3, 2024
7 checks passed
@sven1977 sven1977 deleted the enhance_env_render_examples branch June 3, 2024 15:17
richardsliu pushed a commit to richardsliu/ray that referenced this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants