Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data] Rename ParquetBaseDatasource to ParquetBulkDatasource #45728

Merged
merged 1 commit into from
Jun 5, 2024
Merged

[Data] Rename ParquetBaseDatasource to ParquetBulkDatasource #45728

merged 1 commit into from
Jun 5, 2024

Conversation

bveeramani
Copy link
Member

Why are these changes needed?

Related issue number

ParquetDatasource used to extend from ParquetBaseDatasource. However, after #40900, ParquetBaseDatasource is only used by read_bulk_datasource. To reflect this change, this PR renames ParquetBaseDatasource to ParquetBulkDatasource.

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@bveeramani
Rename ParquetBaseDatasource
776ebd4 
Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani bveeramani enabled auto-merge (squash) June 4, 2024 23:27
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Jun 4, 2024
@bveeramani bveeramani merged commit 9fcd377 into ray-project:master Jun 5, 2024
6 checks passed
richardsliu pushed a commit to richardsliu/ray that referenced this pull request Jun 12, 2024
@bveeramani @richardsliu
[Data] Rename ParquetBaseDatasource to ParquetBulkDatasource (ray…
ec08672 
…-project#45728)

ParquetDatasource used to extend from ParquetBaseDatasource. However, after ray-project#40900, ParquetBaseDatasource is only used by read_bulk_datasource. To reflect this change, this PR renames ParquetBaseDatasource to ParquetBulkDatasource.

Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Richard Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulchen raulchen raulchen approved these changes

@ericl ericl Awaiting requested review from ericl

@scv119 scv119 Awaiting requested review from scv119

@c21 c21 Awaiting requested review from c21

@amogkam amogkam Awaiting requested review from amogkam

@scottjlee scottjlee Awaiting requested review from scottjlee scottjlee is a code owner

@stephanie-wang stephanie-wang Awaiting requested review from stephanie-wang stephanie-wang is a code owner

@omatthew98 omatthew98 Awaiting requested review from omatthew98 omatthew98 is a code owner

Assignees

@raulchen raulchen

Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bveeramani @raulchen