Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Fix DreamerV3 bug for num_env_runners > 0 (users should use num_envs_per_env_runner > 1 instead, though). #45819

Merged
merged 1 commit into from
Jun 10, 2024
Merged

[RLlib] Fix DreamerV3 bug for num_env_runners > 0 (users should use num_envs_per_env_runner > 1 instead, though). #45819

merged 1 commit into from
Jun 10, 2024
+27 −11

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Jun 8, 2024

Fix DreamerV3 bug for num_env_runners > 0.
Note that users should use num_envs_per_env_runner > 1 instead, though.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977
wip
fb4e6ed 
Signed-off-by: sven1977 <[email protected]>
@sven1977 sven1977 enabled auto-merge (squash) June 8, 2024 11:25
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Jun 8, 2024
@sven1977 sven1977 added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Jun 8, 2024
simonsays1980
simonsays1980 approved these changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sven1977 sven1977 merged commit 13940c9 into ray-project:master Jun 10, 2024
7 checks passed
@sven1977 sven1977 deleted the dreamer_v3_fix_env_runner_scaling branch June 11, 2024 12:29
richardsliu pushed a commit to richardsliu/ray that referenced this pull request Jun 12, 2024
@sven1977 @richardsliu
[RLlib] Fix DreamerV3 bug for num_env_runners > 0 (users should use…
0b846e3 
… `num_envs_per_env_runner > 1` instead, though). (ray-project#45819)

Signed-off-by: Richard Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonsays1980 simonsays1980 simonsays1980 approved these changes

@ArturNiederfahrenhorst ArturNiederfahrenhorst Awaiting requested review from ArturNiederfahrenhorst

Assignees

@simonsays1980 simonsays1980

Labels
go add ONLY when ready to merge, run all tests tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sven1977 @simonsays1980