[RLlib] Cleanup examples folder: Cleaned-up PyFlyt example. #45956
+38
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: simonsays1980 <[email protected]>
simonsays1980
added
rllib
sven1977
reviewed
Jun 14, 2024
| elif args.run == "IMPALA": | ||
| config.rollouts(num_rollout_workers=2) | ||
| config.resources(num_gpus=0) | ||
| config.env_runners(num_env_runners=2) |
There was a problem hiding this comment.
Thanks for cleaning this up.
sven1977
reviewed
Jun 14, 2024
| .env_runners( | ||
| num_envs_per_env_runner=args.num_envs_per_env_runner, | ||
| ) | ||
| .reporting(min_time_s_per_iteration=0.1) |
There was a problem hiding this comment.
Do we need this setting? Seems unnecessary.
sven1977
reviewed
Jun 14, 2024
| @@ -30,6 +39,9 @@ | |||
| EPISODE_RETURN_MEAN, | |||
| TRAINING_ITERATION_TIMER, | |||
| ) | |||
| from ray.tune.registry import get_trainable_cls, register_env | |||
|
|
|||
| sys.setrecursionlimit(3000) | |||
There was a problem hiding this comment.
Can we add comment on why this is needed?
sven1977
changed the title
sven1977
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The user-contributed example was running, but needed to get the same standard docs. In addition a couple of deprecated methods was replaced with the actual ones.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.