[core] fiber: increase fiber stack size #46133
Merged
+0
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hongchaodeng
changed the title
hongchaodeng
force-pushed
the
build-fiber-protected
branch
from
a0a1bbe
to
a1c5a9e
Compare
hongchaodeng
requested review from
sven1977,
ArturNiederfahrenhorst,
simonsays1980,
ericl,
architkulkarni and
a team
as code owners
hongchaodeng
force-pushed
the
build-fiber-protected
branch
2 times, most recently
from
b68e531
to
602fd5a
Compare
hongchaodeng
force-pushed
the
build-fiber-protected
branch
from
602fd5a
to
d64baa0
Compare
Signed-off-by: hongchaodeng <[email protected]>
hongchaodeng
requested review from
jjyao
and removed request for
a team,
ericl,
simonsays1980,
architkulkarni,
sven1977 and
ArturNiederfahrenhorst
hongchaodeng
force-pushed
the
build-fiber-protected
branch
from
d64baa0
to
da0963d
Compare
hongchaodeng
changed the title
jjyao
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
When vLLm updated some dependencies, they had hit issues of stack overflow.
I'm increasing the stack size to unblock the issue for now.
Meanwhile I will work on a patch to get rid of fiber since we don't need fiber anymore. That work should resolve the stack issue completely.
Related issue number
#46086
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.