Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Ensure InputDataBuffer doesn't free block references #46191

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

bveeramani
Copy link
Member

@bveeramani bveeramani commented Jun 21, 2024

Why are these changes needed?

See #46282.

Related issue number

Fixes #46282

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani bveeramani marked this pull request as ready for review June 26, 2024 22:42
@bveeramani bveeramani enabled auto-merge (squash) June 26, 2024 22:57
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Jun 26, 2024
@bveeramani bveeramani merged commit 0c44e28 into ray-project:master Jun 26, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Data] Ray can't reconstruct inputs if Python garbage collects input references
2 participants