Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Cleanup examples folder 17: Add example for custom RLModule with an LSTM. #46276

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Jun 26, 2024

Cleanup examples folder 17: Add example for custom RLModule with an LSTM.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: sven1977 <[email protected]>
…nup_examples_folder_17_custom_rl_module_w_lstm
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
…nup_examples_folder_17_custom_rl_module_w_lstm
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

def setup(self):
"""Use this method to create all the model components that you require.

Feel free to access the following useful properties in this class:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should add this super neat docstrings also to the classes I have written. Really good idea!

@sven1977 sven1977 enabled auto-merge (squash) June 27, 2024 09:50
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Jun 27, 2024
Signed-off-by: sven1977 <[email protected]>
@github-actions github-actions bot disabled auto-merge June 27, 2024 12:26
Signed-off-by: sven1977 <[email protected]>
@sven1977 sven1977 merged commit b73d6d4 into ray-project:master Jun 27, 2024
6 checks passed
@sven1977 sven1977 deleted the cleanup_examples_folder_17_custom_rl_module_w_lstm branch June 27, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants