Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Fix test case: Multi-agent CartPole IMPALA (needed 1 more CPU). #46292

Merged
merged 2 commits into from
Jun 27, 2024
Merged

[RLlib] Fix test case: Multi-agent CartPole IMPALA (needed 1 more CPU). #46292

merged 2 commits into from
Jun 27, 2024
+3 −3

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Jun 27, 2024 •
edited
Loading

Fix test case: Multi-agent CartPole IMPALA (needed 1 more CPU).

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977
wip
2d41632 
Signed-off-by: sven1977 <[email protected]>
@sven1977
wip
08c4d85 
Signed-off-by: sven1977 <[email protected]>
simonsays1980
simonsays1980 approved these changes Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

rllib/tuned_examples/impala/multi_agent_cartpole_impala.py
grad_clip=30.0,
grad_clip_by="global_norm",
lr=0.00065,
lr=0.0005,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's a big change in learning rate.

@sven1977 sven1977 enabled auto-merge (squash) June 27, 2024 09:19
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Jun 27, 2024
@sven1977 sven1977 merged commit 9e1d4fe into ray-project:master Jun 27, 2024
8 checks passed
@sven1977 sven1977 deleted the fix_test_case_multi_agent_cartpole_impala_1cpu branch June 27, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonsays1980 simonsays1980 simonsays1980 approved these changes

@ArturNiederfahrenhorst ArturNiederfahrenhorst Awaiting requested review from ArturNiederfahrenhorst

Assignees

@simonsays1980 simonsays1980

Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sven1977 @simonsays1980