Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Fix the display of task/actor GPU info. #46295

Closed
wants to merge 2 commits into from

Conversation

liuxsh9
Copy link
Contributor

@liuxsh9 liuxsh9 commented Jun 27, 2024

Why are these changes needed?

There is a mismatch between the front-end and back-end variables. Front-end: processes, Back-end: processes_pid. Modify the variable name to resolve this issue.

After:

image

image

Related issue number

#46213

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@anyscalesam anyscalesam added triage Needs triage (eg: priority, bug/not-bug, and owning component) core Issues that should be addressed in Ray Core labels Aug 2, 2024
@anyscalesam anyscalesam self-requested a review August 2, 2024 07:27
@anyscalesam anyscalesam requested a review from jjyao August 13, 2024 18:28
@anyscalesam anyscalesam added P0 Issues that should be fixed in short order and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Aug 13, 2024
@anyscalesam anyscalesam added the observability Issues related to the Ray Dashboard, Logging, Metrics, Tracing, and/or Profiling label Aug 13, 2024
@jjyao jjyao added the go add ONLY when ready to merge, run all tests label Aug 13, 2024
@jjyao
Copy link
Collaborator

jjyao commented Aug 13, 2024

This has been fixed in #46719

@jjyao jjyao closed this Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues that should be addressed in Ray Core go add ONLY when ready to merge, run all tests observability Issues related to the Ray Dashboard, Logging, Metrics, Tracing, and/or Profiling P0 Issues that should be fixed in short order
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants