[RLlib] Rename all np.product usage to np.prod #46317
Merged
+75
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MaxVanDijck <[email protected]>
MaxVanDijck
requested review from
sven1977,
ArturNiederfahrenhorst,
simonsays1980,
ericl,
scv119,
c21,
amogkam,
scottjlee,
bveeramani,
raulchen,
stephanie-wang and
omatthew98
as code owners
Signed-off-by: MaxVanDijck <[email protected]>
simonsays1980
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
LGTM. Very nice PR. Thanks a ton @MaxVanDijck! Could you merge the master again and push in the branch? Some tests are not passing, yet.
Done, looks like tests are passing now |
sven1977
approved these changes
Jul 11, 2024
|
Auto-merge enabled. Just waiting for the last test to pass ... |
Signed-off-by: MaxVanDijck <[email protected]>
auto-merge was automatically disabled
July 21, 2024 08:47
Head branch was pushed to by a user without write access
|
Many |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The as of numpy version 1.15.0
np.productwas made to be an alias ofnp.prod, and is now deprecated in numpy 2.0.0This pr switches all usage of
np.productto usenp.prodrefer: https://stackoverflow.com/a/49864286
Related issue number
#46250
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.