[serve] remove target_num_ongoing_requests_per_replica #46392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcin
force-pushed
the
pr46392
branch
2 times, most recently
from
c85c2cd
to
fffa335
Compare
zcin
requested review from
edoakes,
shrekris-anyscale,
GeneDer,
akshay-anyscale and
a team
as code owners
edoakes
approved these changes
Jul 5, 2024
|
@edoakes tests are passing, ready for merge |
|
@zcin merge conflict now |
`target_num_ongoing_requests_per_replica` was deprecated in ray 2.10, and `target_ongoing_requests` was introduced at the same time. There have been many releases since then, so we can remove `target_num_ongoing_requests_per_replica` now. Signed-off-by: Cindy Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[serve] remove target_num_ongoing_requests_per_replica
target_num_ongoing_requests_per_replicawas deprecated in ray 2.10, andtarget_ongoing_requestswas introduced at the same time. There have been many releases since then, so we can removetarget_num_ongoing_requests_per_replicanow.Signed-off-by: Cindy Zhang [email protected]