[Core] Add object back to memory store when object recovery is skipped #46460
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
For the periodic
CoreWorker.RecoverObjects
, we remove all objects to recover from the memory store with the expectation thatObjectRecoveryManager::RecoverObject
will guarantee to add the object back to the memory store eventually after recovery. However there is a case that we failed to add the object back to the memory store which is when the recovery is skipped due to existing pin or spill. This PR fixes it by adding the object back to the memory store when recovery is skipped.Sequence of events:
objects_to_recover_
in ReferenceCounter.CoreWorker.RecoverObjects
periodic runner runs, core worker will call RecoverObject(b) but b already has a primary copy (node 4) so the recovery is skipped. Without this PR, b is removed from memory store so future get will hang forever.Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.