Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[train] fix tensorflow example by using ScalingConfig #46565

Merged
merged 3 commits into from
Jul 14, 2024
Merged

[train] fix tensorflow example by using ScalingConfig #46565

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b9cdcf0
soloved ScalingConfig issue
mjovanovic9999 Jul 11, 2024
75ebbcb
soloved ScalingConfig issue; added proper imports
mjovanovic9999 Jul 11, 2024
68e6153
formatting step
mjovanovic9999 Jul 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python/ray/train/examples/tf/tensorflow_autoencoder_example.py
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you run the formatting step?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthewdeng done

Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
from ray.air.integrations.keras import ReportCheckpointCallback
from ray.data.datasource import SimpleTensorFlowDatasource
from ray.data.extensions import TensorArray
from ray.train import Result
from ray.train import Result, ScalingConfig
from ray.train.tensorflow import TensorflowTrainer, prepare_dataset_shard


Expand Down Expand Up @@ -121,7 +121,7 @@ def train_tensorflow_mnist(
) -> Result:
train_dataset = get_dataset(split_type="train")
config = {"lr": 1e-3, "batch_size": 64, "epochs": epochs}
scaling_config = dict(num_workers=num_workers, use_gpu=use_gpu)
scaling_config = ScalingConfig(num_workers=num_workers, use_gpu=use_gpu)
trainer = TensorflowTrainer(
train_loop_per_worker=train_func,
train_loop_config=config,
Expand Down
3 changes: 2 additions & 1 deletion python/ray/train/examples/tf/tune_tensorflow_autoencoder_example.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,13 @@
from ray.train.tensorflow import TensorflowTrainer
from ray.tune.tune_config import TuneConfig
from ray.tune.tuner import Tuner
from ray.train import ScalingConfig


def tune_tensorflow_mnist(
num_workers: int = 2, num_samples: int = 2, use_gpu: bool = False
):
scaling_config = dict(num_workers=num_workers, use_gpu=use_gpu)
scaling_config = ScalingConfig(num_workers=num_workers, use_gpu=use_gpu)
trainer = TensorflowTrainer(
train_loop_per_worker=train_func,
scaling_config=scaling_config,
Expand Down