Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Make working_dir support files created before 1980 #46634

Merged
merged 5 commits into from
Jul 16, 2024

Conversation

jjyao
Copy link
Collaborator

@jjyao jjyao commented Jul 15, 2024

Why are these changes needed?

working_dir runtime env uses ZipFile to create a zip of the working_dir directory. By default, ZipFile doesn't support files created before 1980 however this can happen often if the working_dir directory is a NFS directory. This PR fixes this by disabling strict_timestamps.

Related issue number

Closes #46379

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@jjyao jjyao added the go add ONLY when ready to merge, run all tests label Jul 15, 2024
@rynewang
Copy link
Contributor

Now we are at this - do we also want to set some compressions?

@jjyao
Copy link
Collaborator Author

jjyao commented Jul 15, 2024

Now we are at this - do we also want to set some compressions?

I'll leave it to you as the owner of runtime env :)

@jjyao jjyao merged commit 0ad0b01 into ray-project:master Jul 16, 2024
4 of 5 checks passed
@jjyao jjyao deleted the jjyao/zzip branch July 16, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
2 participants