Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Always print traceback for internal exceptions #46647

Merged

Conversation

bveeramani
Copy link
Member

Why are these changes needed?

If Ray Data raises an internal error (not from the user-provided UDF), then the traceback is mostly hidden.

2024-07-15 20:45:45,956 ERROR exceptions.py:73 -- Exception occurred in Ray Data or Ray Core internal code. If you continue to see this error, please open an issue on the Ray project GitHub page with the full stack trace below: https://github.com/ray-project/ray/issues/new/choose
ray.data.exceptions.SystemException

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/Users/balaji/Documents/GitHub/ray/python/ray/data/tests/1.py", line 3, in <module>
    ray.data.range(1).materialize()
  File "/Users/balaji/Documents/GitHub/ray/python/ray/data/dataset.py", line 4599, in materialize
    copy._plan.execute()
  File "/Users/balaji/Documents/GitHub/ray/python/ray/data/exceptions.py", line 90, in handle_trace
    raise e.with_traceback(None) from SystemException()
RuntimeError: Mock internal error

This output isn't helpful for debugging, so this PR changes the behavior so that the full traceback is printed for all internal errors.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Balaji Veeramani <[email protected]>
Copy link
Contributor

@raulchen raulchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@bveeramani bveeramani enabled auto-merge (squash) July 16, 2024 17:36
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Jul 16, 2024
@bveeramani bveeramani merged commit bb90a82 into ray-project:master Jul 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants