Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Cleanup, rename, clarify: Algorithm.workers/evaluation_workers, local_worker(), etc.. #46726

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Jul 20, 2024

Renames:
Algorithm.workers -> env_runner_group
Algorithm.evaluation_workers -> evaluation_env_runner_group
EnvRunnerGroup.local_worker -> local_env_runner

Adds shortcuts:
Algorithm.env_runner -> Algorithm.env_runner_group.local_env_runner
Algorithm.eval_env_runner -> Algorithm.evaluation_env_runner_group.local_env_runner

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: sven1977 <[email protected]>
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One last thing I guess: Now, where the new Offline RL API is merged, we need to apply these renaming also to BC.

Signed-off-by: sven1977 <[email protected]>
…me_algo_workers_to_algo_env_runner_group

Signed-off-by: sven1977 <[email protected]>

# Conflicts:
#	rllib/algorithms/bc/bc.py
@sven1977 sven1977 enabled auto-merge (squash) July 22, 2024 09:33
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Jul 22, 2024
@sven1977
Copy link
Contributor Author

Good point. Done right now through master merge (conflict resolution).

Signed-off-by: sven1977 <[email protected]>
@github-actions github-actions bot disabled auto-merge July 22, 2024 11:34
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
@sven1977 sven1977 enabled auto-merge (squash) July 22, 2024 16:26
@sven1977 sven1977 merged commit 710f557 into ray-project:master Jul 22, 2024
6 checks passed
@sven1977 sven1977 deleted the rename_algo_workers_to_algo_env_runner_group branch July 23, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants