[RLlib] Move DQN into the TargetNetworkAPI (and deprecate RLModuleWithTargetNetworksInterface).
#46752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sven1977 <[email protected]>
simonsays1980
approved these changes
Jul 23, 2024
| @@ -105,7 +106,7 @@ def __init__(self, algo_class=None): | |||
| self.num_multi_gpu_tower_stacks = 1 | |||
| self.minibatch_buffer_size = 1 | |||
| self.num_sgd_iter = 1 | |||
| self.target_update_frequency = 1 | |||
| self.target_network_update_freq = 1 | |||
| lambda mid, module: ( | ||
| module.sync_target_networks(tau=1.0) | ||
| if hasattr(module, "sync_target_networks") | ||
| lambda mid, mod: ( |
There was a problem hiding this comment.
Yeah, this was such a hack.
|
Good point! WE haven't re-merged the +GPU +multi-GPU +multi-agent tests for DQN + SAC yet, correct? |
Signed-off-by: sven1977 <[email protected]>
No, we haven't because they are flaky on the CI machines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move DQN into the TargetNetworkAPI (and deprecate
RLModuleWithTargetNetworksInterface).TorchDDPRLModuleWithTargetNetworksInterface.Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.