Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc][build/02] remove site-packages from global cache #46797

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Conversation

can-anyscale
Copy link
Collaborator

@can-anyscale can-anyscale commented Jul 25, 2024

Redo ff789b9; the previous attempt is missing sphinx as a runtime dependency (sphinx is a runtime dependency of pickle, it happens only at runtime)

Test:

…6781)

The generated doc build files might include local files, such as local
python site-packages. Remove these files since they cannot be used as a
global cache.

Test:
- CI

Signed-off-by: can <[email protected]>
@can-anyscale can-anyscale force-pushed the can-db02 branch 2 times, most recently from 9bd3aae to 6d71e57 Compare July 25, 2024 17:58
@@ -9,7 +9,6 @@ freezegun
google-cloud-storage
jinja2
protobuf >= 3.15.3, != 3.19.5
pydantic < 1.10.0
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing is using this package, but it is conflicting with requirements-doc.txt

@can-anyscale can-anyscale changed the title Can db02 [doc][build/02] remove local site-package files from global c Jul 25, 2024
@can-anyscale can-anyscale changed the title [doc][build/02] remove local site-package files from global c [doc][build/02] remove site-packages from global cache Jul 25, 2024
@can-anyscale can-anyscale marked this pull request as ready for review July 25, 2024 18:55
@can-anyscale can-anyscale requested a review from a team as a code owner July 25, 2024 18:55
@can-anyscale can-anyscale enabled auto-merge (squash) July 26, 2024 19:46
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Jul 26, 2024
@can-anyscale can-anyscale merged commit 92acf8e into master Jul 26, 2024
7 checks passed
@can-anyscale can-anyscale deleted the can-db02 branch July 26, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants