[serve] Deprecate passing DeploymentResponse to handle #46806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cindy Zhang <[email protected]>
Signed-off-by: Cindy Zhang <[email protected]>
Signed-off-by: Cindy Zhang <[email protected]>
zcin
requested review from
edoakes,
shrekris-anyscale,
GeneDer,
akshay-anyscale and
a team
as code owners
Signed-off-by: Cindy Zhang <[email protected]>
akshay-anyscale
approved these changes
Jul 31, 2024
edoakes
reviewed
Jul 31, 2024
| @@ -449,6 +449,13 @@ async def _resolve_deployment_responses( | |||
| ) | |||
| elif isinstance(obj, DeploymentResponse): | |||
| responses.append(obj) | |||
| if obj not in request_args and obj not in request_kwargs.values(): | |||
There was a problem hiding this comment.
I assume you've tested that this check works and we don't spuriously print?
There was a problem hiding this comment.
Yup, this will only print for deployment response objects that weren't passed in as top level args/kwargs.
edoakes
approved these changes
Jul 31, 2024
zcin
force-pushed
the
deprecate-dep-resp-arg
branch
from
8e727cc
to
8e3aaa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Deprecate passing a deployment response to a handle by reference (docs).
Supporting this requires using pyobjscanner to recursively process and pickle dump all args, which adds to the latency especially for large payloads.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.