-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RLlib; Offline RL] Offline recording new api stack #46818
Merged
sven1977
merged 11 commits into
ray-project:master
from
simonsays1980:offline-recording-new-api-stack
Aug 1, 2024
Merged
[RLlib; Offline RL] Offline recording new api stack #46818
sven1977
merged 11 commits into
ray-project:master
from
simonsays1980:offline-recording-new-api-stack
Aug 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: simonsays1980 <[email protected]>
Signed-off-by: simonsays1980 <[email protected]>
Signed-off-by: simonsays1980 <[email protected]>
sven1977
changed the title
[RLlib - Offline RL] - Offline recording new api stack
[RLlib; Offline RL] Offline recording new api stack
Jul 29, 2024
sven1977
requested review from
sven1977 and
ArturNiederfahrenhorst
as code owners
July 29, 2024 10:26
sven1977
reviewed
Jul 29, 2024
sven1977
reviewed
Jul 29, 2024
sven1977
reviewed
Jul 29, 2024
…rthermore, tested running 'truncate_episodes' batch mode. Signed-off-by: simonsays1980 <[email protected]>
…hrough sampled episodes. Signed-off-by: simonsays1980 <[email protected]>
Signed-off-by: simonsays1980 <[email protected]>
8 tasks
Signed-off-by: sven1977 <[email protected]>
sven1977
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now ... Thanks @simonsays1980 !
…tributes ofr and in the 'OfflineEnvRunner'. Signed-off-by: simonsays1980 <[email protected]>
Signed-off-by: simonsays1980 <[email protected]>
Signed-off-by: simonsays1980 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The new API stack has no recording possibility, yet, to store experiences to disk. This PR proposes this feature by overriding the
EnvRunner
to not only sample results but also store them to disk (or cloud storage) with different storing methods. It does so by overriding sampling toEpisodeType
episodes directly,Furthermore, it uses
ray.data
natively, i.e. users can define how the data should be stored by passing in one ofray.data
's writing methods (see https://docs.ray.io/en/latest/data/api/input_output.html).The idea behind overriding the
EnvvRunner
for sampling is to write datasets in parallel from workers and not sending data around to the driver. This enables to store massive data blazingly fast. This will be needed for offline RL and is specifically handy when running on the cloud writing into blob storage.Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.