Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib; Offline RL] Offline recording new api stack #46818

Merged

Conversation

simonsays1980
Copy link
Collaborator

@simonsays1980 simonsays1980 commented Jul 26, 2024

Why are these changes needed?

The new API stack has no recording possibility, yet, to store experiences to disk. This PR proposes this feature by overriding the EnvRunner to not only sample results but also store them to disk (or cloud storage) with different storing methods. It does so by overriding sampling to

  1. Store EpisodeType episodes directly,
  2. Or column data generated during sampling parallel to episodes.

Furthermore, it uses ray.data natively, i.e. users can define how the data should be stored by passing in one of ray.data's writing methods (see https://docs.ray.io/en/latest/data/api/input_output.html).

The idea behind overriding the EnvvRunner for sampling is to write datasets in parallel from workers and not sending data around to the driver. This enables to store massive data blazingly fast. This will be needed for offline RL and is specifically handy when running on the cloud writing into blob storage.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977 sven1977 changed the title [RLlib - Offline RL] - Offline recording new api stack [RLlib; Offline RL] Offline recording new api stack Jul 29, 2024
@sven1977 sven1977 marked this pull request as ready for review July 29, 2024 10:26
…rthermore, tested running 'truncate_episodes' batch mode.

Signed-off-by: simonsays1980 <[email protected]>
…hrough sampled episodes.

Signed-off-by: simonsays1980 <[email protected]>
@sven1977 sven1977 enabled auto-merge (squash) July 30, 2024 14:40
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Jul 30, 2024
Signed-off-by: sven1977 <[email protected]>
@github-actions github-actions bot disabled auto-merge July 30, 2024 14:57
Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now ... Thanks @simonsays1980 !

@sven1977 sven1977 enabled auto-merge (squash) July 30, 2024 14:58
…tributes ofr and in the 'OfflineEnvRunner'.

Signed-off-by: simonsays1980 <[email protected]>
Signed-off-by: simonsays1980 <[email protected]>
@github-actions github-actions bot disabled auto-merge July 31, 2024 09:12
@sven1977 sven1977 merged commit 0edf156 into ray-project:master Aug 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants