[RLlib] Add more detailed options to `Algorithm.add_module/remove_module`. #46836

sven1977 · 2024-07-29T07:43:29Z

Add more detailed options to Algorithm.add_module/remove_module.

Why are these changes needed?

I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
I've run scripts/format.sh to lint the changes in this PR.
I've included any doc changes needed for https://docs.ray.io/en/master/.
- I've added any new APIs to the API Reference. For example, if I added a
  method in Tune, I've added it in doc/source/tune/api/ under the
  corresponding .rst file.
I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
Testing Strategy
- Unit tests
- Release tests
- This PR is not tested :(

Signed-off-by: sven1977 <[email protected]>

simonsays1980

LGTM. Very nice PR!

simonsays1980 · 2024-07-29T08:43:18Z

rllib/core/rl_module/__init__.py

+
+
+@PublicAPI(stability="alpha")
+def validate_module_id(policy_id: str, error: bool = False) -> None:


Very nice!!

Signed-off-by: sven1977 <[email protected]>

wip

f9daa31

Signed-off-by: sven1977 <[email protected]>

sven1977 requested review from ArturNiederfahrenhorst and simonsays1980 as code owners July 29, 2024 07:43

sven1977 assigned simonsays1980 Jul 29, 2024

wip

de51be5

Signed-off-by: sven1977 <[email protected]>

simonsays1980 approved these changes Jul 29, 2024

View reviewed changes

wip

a02b76f

Signed-off-by: sven1977 <[email protected]>

sven1977 enabled auto-merge (squash) July 29, 2024 12:57

github-actions bot added the go add ONLY when ready to merge, run all tests label Jul 29, 2024

sven1977 merged commit 8a7960f into ray-project:master Jul 29, 2024
7 checks passed

sven1977 deleted the add_training_workers_option_to_add_module_api branch July 30, 2024 06:32



		@PublicAPI(stability="alpha")
		def validate_module_id(policy_id: str, error: bool = False) -> None: