Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Rename MultiAgent...RLModule... into MultiRL...Module for more generality. #46840

Merged
merged 7 commits into from
Jul 30, 2024
Merged

[RLlib] Rename MultiAgent...RLModule... into MultiRL...Module for more generality. #46840

merged 7 commits into from
Jul 30, 2024

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Jul 29, 2024 •
edited
Loading

Rename MultiAgent...RLModule... into MultiRL...Module for more generality.

  • A MultiRLModule might be used for multi-agent (each agent has one RLModule)
  • But it may also be used for non multi-agent applications, such as curiosity (using a separate world-model).
  • Also, some multi-agent cases are not strictly one-agent-one-module, but could have shared components (shared value function).

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977
wip
d6a2a1b 
Signed-off-by: sven1977 <[email protected]>
@sven1977
wip
7f7a3ad 
Signed-off-by: sven1977 <[email protected]>
@sven1977
wip
cda8fef 
Signed-off-by: sven1977 <[email protected]>
@sven1977 sven1977 enabled auto-merge (squash) July 29, 2024 13:12
@github-actions github-actions bot disabled auto-merge July 29, 2024 13:13
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Jul 29, 2024
simonsays1980
simonsays1980 approved these changes Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is going to be a bigger change in the docs. I am not sure, if, this has been changed everywhere already.

@sven1977
fix
6a02c2e 
Signed-off-by: sven1977 <[email protected]>
@sven1977 sven1977 enabled auto-merge (squash) July 29, 2024 14:43
@github-actions github-actions bot disabled auto-merge July 29, 2024 14:43
@sven1977
fix
6255166 
Signed-off-by: sven1977 <[email protected]>
@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into rena…
aa4ab35 
…me_marl_module_into_multi_rl_module

Signed-off-by: sven1977 <[email protected]>

# Conflicts:
#	rllib/algorithms/algorithm.py
#	rllib/algorithms/algorithm_config.py
#	rllib/core/learner/learner.py
#	rllib/core/learner/learner_group.py
#	rllib/core/rl_module/__init__.py
#	rllib/core/rl_module/marl_module.py
#	rllib/env/env_runner_group.py
#	rllib/evaluation/rollout_worker.py
@sven1977
wip
cfb90b4 
Signed-off-by: sven1977 <[email protected]>
@sven1977 sven1977 merged commit 3990a0e into ray-project:master Jul 30, 2024
5 checks passed
@sven1977 sven1977 deleted the rename_marl_module_into_multi_rl_module branch July 31, 2024 14:15
@Kakadus Kakadus mentioned this pull request Aug 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@can-anyscale can-anyscale can-anyscale approved these changes

@simonsays1980 simonsays1980 simonsays1980 approved these changes

@ArturNiederfahrenhorst ArturNiederfahrenhorst Awaiting requested review from ArturNiederfahrenhorst

@maxpumperla maxpumperla Awaiting requested review from maxpumperla maxpumperla is a code owner

Assignees

@simonsays1980 simonsays1980

Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sven1977 @simonsays1980 @can-anyscale