Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] fix PinExistingReturnObject segfault by passing owner_address #46973

Merged
merged 1 commit into from
Aug 6, 2024
Merged

[core] fix PinExistingReturnObject segfault by passing owner_address #46973

merged 1 commit into from
Aug 6, 2024
+105 −7

Commits on Aug 6, 2024

  1. [core] fix PinExistingReturnObject segfault by passing owner_address 

    When worker crash-restarts, there is a chance that it would call
PinExistingReturnObject() to pin existing objects.
But PinExistingReturnObject() calls GetThreadContext() which doesn't work
for async actor methods.
The owner_address is already there before calling PinExistingReturnObject().
This fix try to avoid the segfault by passing owner_address to PinExistingReturnObject().

Signed-off-by: hongchaodeng <[email protected]>
    @hongchaodeng
    hongchaodeng committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    86cd5e3 View commit details
    Browse the repository at this point in the history