Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Add ray[adag] option to pip install #47009

Merged
merged 13 commits into from
Aug 14, 2024
Merged

[Core] Add ray[adag] option to pip install #47009

merged 13 commits into from
Aug 14, 2024

Conversation

ruisearch42
Copy link
Contributor

Why are these changes needed?

Add ray[adag] option to pip install

Related issue number

Closes #46945

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@ruisearch42
[Core] Add ray[adag] option to pip install
f2d7980 
Signed-off-by: Rui Qiao <[email protected]>
@ruisearch42
up
236121d 
Signed-off-by: Rui Qiao <[email protected]>
@ruisearch42
up
f94df2c 
Signed-off-by: Rui Qiao <[email protected]>
@ruisearch42
up
cde3d99 
Signed-off-by: Rui Qiao <[email protected]>
@ruisearch42
up
47c557e 
Signed-off-by: Rui Qiao <[email protected]>
@rkooo567 rkooo567 self-assigned this Aug 13, 2024
@ruisearch42
up
4572cc3 
Signed-off-by: Rui Qiao <[email protected]>
@ruisearch42
up
61468a3 
Signed-off-by: Rui Qiao <[email protected]>
@ruisearch42
up
715a276 
Signed-off-by: Rui Qiao <[email protected]>
@ruisearch42
up
c0f1a33 
Signed-off-by: Rui Qiao <[email protected]>
@ruisearch42
up
2e11fc1 
Signed-off-by: Rui Qiao <[email protected]>
@ruisearch42
up
e428bab 
Signed-off-by: Rui Qiao <[email protected]>
rkooo567
rkooo567 reviewed Aug 13, 2024
View reviewed changes
Copy link
Contributor

@rkooo567 rkooo567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty good. have you manually tested it btw?

python/ray/util/collective/requirements.txt Outdated Show resolved Hide resolved
python/requirements/ml/dl-cpu-requirements.txt Outdated Show resolved Hide resolved
@ruisearch42
up
0f966c4 
Signed-off-by: Rui Qiao <[email protected]>
@ruisearch42 ruisearch42 added the go add ONLY when ready to merge, run all tests label Aug 13, 2024
@ruisearch42 ruisearch42 marked this pull request as ready for review August 13, 2024 23:48
@ruisearch42
Copy link
Contributor Author

looks pretty good. have you manually tested it btw?

Tested with a local pip install with adag option and it works fine.

@rkooo567 rkooo567 enabled auto-merge (squash) August 14, 2024 04:32
@rkooo567
Copy link
Contributor

@angelinalg can you approve this PR? there is a doc change that needs your approval

@ruisearch42
up
15032b9 
Signed-off-by: Rui Qiao <[email protected]>
@github-actions github-actions bot disabled auto-merge August 14, 2024 07:04
@rkooo567 rkooo567 enabled auto-merge (squash) August 14, 2024 16:30
angelinalg
angelinalg approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@angelinalg angelinalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamp

@rkooo567 rkooo567 merged commit a0f7a7d into ray-project:master Aug 14, 2024
6 checks passed
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Aug 15, 2024
@ruisearch42 @simonsays1980
[Core] Add ray[adag] option to pip install (ray-project#47009)
2626ea7 
Add ray[adag] option to pip install
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelinalg angelinalg angelinalg approved these changes

@rkooo567 rkooo567 rkooo567 approved these changes

@edoakes edoakes edoakes approved these changes

@richardliaw richardliaw Awaiting requested review from richardliaw richardliaw is a code owner

@ericl ericl Awaiting requested review from ericl

Assignees

@rkooo567 rkooo567

Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[core][experimental] Add ray[adag] option to pip install
4 participants
@ruisearch42 @rkooo567 @edoakes @angelinalg