Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Don't sync (old API stack) connector states after worker restore. #47021

Merged
merged 5 commits into from
Aug 16, 2024
Merged

[RLlib] Don't sync (old API stack) connector states after worker restore. #47021

merged 5 commits into from
Aug 16, 2024
+42 −15

Commits on Aug 8, 2024

  1. Bug goes away if we do NOT sync the just restarted workers (inside Al… 

    …gorithm.restore_workers) directly after their recovery.

Signed-off-by: sven1977 <[email protected]>
    @sven1977
    sven1977 committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    cf891bd View commit details
    Browse the repository at this point in the history

  2. Bug goes away if we do NOT sync the just restarted workers (inside Al… 

    …gorithm.restore_workers) directly after their recovery.

Signed-off-by: sven1977 <[email protected]>
    @sven1977
    sven1977 committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    951286c View commit details
    Browse the repository at this point in the history

  3. Problem fixed by hard-removing the connector states from the local wo… 

    …rker's state after a worker has been restored and before it is synched with the local worker's state.

The re-creation of the connectors on the already instantiated (restored) new worker broke things, b/c the AgentCollector that one of the "agent" connector pieces points to has already undergone some change and is then re-created, which breaks the stored vf-pred value (and other "extra fetches").

Signed-off-by: sven1977 <[email protected]>
    @sven1977
    sven1977 committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    e4c7ea3 View commit details
    Browse the repository at this point in the history

  4. wip 

    Signed-off-by: sven1977 <[email protected]>
    @sven1977
    sven1977 committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    de48209 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. Merge branch 'master' into dont_sync_connector_states_after_worker_re… 

    …store
    @sven1977
    sven1977 authored Aug 16, 2024
    Configuration menu
    Copy the full SHA
    7e0b8fc View commit details
    Browse the repository at this point in the history