Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Only show message regarding hiding op-level progress bar once #47029

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

scottjlee
Copy link
Contributor

Why are these changes needed?

#46826 introduced a bug, where the info log regarding hiding operator-level progress bars is always shown, regardless of whether the code was run via a Ray Job or not.

This PR fixes the bug by moving the check for whether the code is run via a Ray Job or not into the DataContext.__post_init__() method, so that the check is done only after the DataContext singleton is initialized.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Contributor

@omatthew98 omatthew98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one step forwards one step backwards, but we march the progress bar onwards.

@scottjlee scottjlee added the go add ONLY when ready to merge, run all tests label Aug 8, 2024
Signed-off-by: Scott Lee <[email protected]>
@bveeramani bveeramani merged commit fa118e2 into ray-project:master Aug 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants