Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Examples folder cleanup: Add example script for Env with protobuf observation space. #47071

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Aug 10, 2024

Examples folder cleanup: Add example script for Env with protobuf observation space.

PR adds:

  • Env class that uses a protobuf (binary string) observation space.
  • ConnectorV2 piece that decodes the protobuf and translates it into a NN-readable tensor.
  • Example script showing that CartPole w/ protobuf space can be learnt normally by PPO.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
@sven1977 sven1977 enabled auto-merge (squash) August 12, 2024 08:12
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Aug 12, 2024
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Awesome example!

@sven1977 sven1977 merged commit fd6a8bf into ray-project:master Aug 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants