Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data] Fix validation bug when size=0 in ActorPoolStrategy #47072

Merged
merged 1 commit into from
Aug 15, 2024
Merged

[Data] Fix validation bug when size=0 in ActorPoolStrategy #47072

merged 1 commit into from
Aug 15, 2024

Conversation

xingyu-long
Copy link
Contributor

@xingyu-long xingyu-long commented Aug 10, 2024 •
edited
Loading

Why are these changes needed?

To resolve the issue 40393 and we need to check if size is not None beforehand.

Related issue number

Closes #40393

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@xingyu-long xingyu-long mentioned this pull request Aug 10, 2024
Closed
@anyscalesam anyscalesam added triage Needs triage (eg: priority, bug/not-bug, and owning component) data Ray Data-related issues labels Aug 12, 2024
@xingyu-long
Copy link
Contributor Author

xingyu-long commented Aug 14, 2024 •
edited
Loading

Hi @anyscalesam, could you review this change? thanks!

@bveeramani bveeramani changed the title Fix the leak when size=0 in ActorPoolStrategy [Data] Fix validation bug when size=0 in ActorPoolStrategy Aug 15, 2024
@bveeramani bveeramani enabled auto-merge (squash) August 15, 2024 18:01
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Aug 15, 2024
@bveeramani bveeramani merged commit 3351a46 into ray-project:master Aug 15, 2024
7 checks passed
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Aug 16, 2024
@xingyu-long @simonsays1980
[Data] Fix validation bug when size=0 in ActorPoolStrategy (ray-proje…
12c413d 
…ct#47072)

To resolve the issue 40393 and we need to check if size is not None beforehand.

Signed-off-by: Xingyu Long <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottjlee scottjlee scottjlee approved these changes

@ericl ericl Awaiting requested review from ericl

@scv119 scv119 Awaiting requested review from scv119

@c21 c21 Awaiting requested review from c21

@amogkam amogkam Awaiting requested review from amogkam

@bveeramani bveeramani Awaiting requested review from bveeramani bveeramani is a code owner

@raulchen raulchen Awaiting requested review from raulchen raulchen is a code owner

@stephanie-wang stephanie-wang Awaiting requested review from stephanie-wang stephanie-wang is a code owner

@omatthew98 omatthew98 Awaiting requested review from omatthew98 omatthew98 is a code owner

Assignees
No one assigned
Labels
data Ray Data-related issues go add ONLY when ready to merge, run all tests triage Needs triage (eg: priority, bug/not-bug, and owning component)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Able to pass size=0 in ActorPoolStrategy
4 participants
@xingyu-long @scottjlee @bveeramani @anyscalesam