[RLlib; Offline RL] Implement twin-Q net option for CQL. #47105
Merged
+114
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: simonsays1980 <[email protected]>
simonsays1980
requested review from
sven1977 and
ArturNiederfahrenhorst
as code owners
sven1977
changed the title
sven1977
changed the title
sven1977
reviewed
Aug 13, 2024
| @@ -90,8 +92,9 @@ def compute_loss_for_module( | |||
| # Use the actions sampled from the current policy. | |||
| Columns.ACTIONS: actions_curr, | |||
| } | |||
| # Note, if `twin_q` is `True`, `compute_q_values` computes the minimum | |||
sven1977
reviewed
Aug 13, 2024
| if config.twin_q: | ||
| td_error += torch.abs(q_twin_selected, q_selected_target) | ||
| # Rescale the TD error | ||
| td_error += 0.5 |
There was a problem hiding this comment.
Great catch :D This should be multiplied by 0.5
sven1977
reviewed
Aug 13, 2024
| @@ -144,15 +150,24 @@ def compute_loss_for_module( | |||
| # Calculate the TD error. | |||
| td_error = torch.abs(q_selected - q_selected_target) | |||
| # TODO (simon): Add the Twin TD error | |||
| if config.twin_q: | |||
| td_error += torch.abs(q_twin_selected, q_selected_target) | |||
There was a problem hiding this comment.
Should this be torch.minimum?
There was a problem hiding this comment.
Sorry, meant: Should this be torch.abs(q_twin_selected - q_selected_target)
sven1977
reviewed
Aug 13, 2024
| @@ -144,15 +150,24 @@ def compute_loss_for_module( | |||
| # Calculate the TD error. | |||
| td_error = torch.abs(q_selected - q_selected_target) | |||
| # TODO (simon): Add the Twin TD error | |||
There was a problem hiding this comment.
Another good catch :)
sven1977
reviewed
Aug 13, 2024
| * config.min_q_weight | ||
| * config.temperature | ||
| ) | ||
| cql_twin_loss - (q_twin_selected.mean()) * config.min_q_weight |
There was a problem hiding this comment.
Should this be -=?
Could you check all the math also once more? I don't want to miss anything important here :)
There was a problem hiding this comment.
Oh yes good catch. I hope I just missed the = key and its not my eyes :)
…the math. Signed-off-by: simonsays1980 <[email protected]>
Signed-off-by: simonsays1980 <[email protected]>
sven1977
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
LGTM now. Thanks for this great PR and for double-checking @simonsays1980 .
simonsays1980
added a commit
to simonsays1980/ray
that referenced
this pull request
Aug 14, 2024
simonsays1980
added a commit
to simonsays1980/ray
that referenced
this pull request
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR proposes the double Q trick for CQL to stabilize training. More specifically
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.