Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serve] split test_proxy.py into unit and e2e tests #47112

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

zcin
Copy link
Contributor

@zcin zcin commented Aug 13, 2024

Why are these changes needed?

Split out TestHTTPProxy and TestgRPCProxy into a unit test file.

pytest -vs python/ray/serve/tests/unit/test_proxy.py                                                                                                                                                                                                                       ─╯
2024-08-13 11:35:28,759 WARNING api.py:346 -- The default value for `max_ongoing_requests` has changed from 100 to 5 in Ray 2.32.0.
2024-08-13 11:35:28,759 WARNING api.py:397 -- The default value for `max_ongoing_requests` has changed from 100 to 5 in Ray 2.32.0.
============================================================================================================================= test session starts ==============================================================================================================================
platform darwin -- Python 3.9.12, pytest-7.4.0, pluggy-1.2.0 -- /Users/cindyz/miniforge3/envs/ray/bin/python
cachedir: .pytest_cache
rootdir: /Users/cindyz/ray
configfile: pytest.ini
plugins: docker-tools-3.1.3, asyncio-0.21.1, anyio-3.7.1
asyncio: mode=strict
collected 26 items

python/ray/serve/tests/unit/test_proxy.py::TestgRPCProxy::test_not_found_response 2024-08-13 11:35:28,801       INFO proxy.py:461 --  STATUSCODE.NOT_FOUND 0.0ms
2024-08-13 11:35:28,802 INFO proxy.py:461 --  STATUSCODE.NOT_FOUND 0.0ms
PASSED
...

============================================================================================================================== 26 passed in 0.05s ==============================================================================================================================

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@zcin zcin requested review from GeneDer and edoakes August 13, 2024 18:35
@zcin zcin added the go add ONLY when ready to merge, run all tests label Aug 13, 2024
Copy link
Contributor

@GeneDer GeneDer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just make sure to fix linting :)

Signed-off-by: Cindy Zhang <[email protected]>
@zcin zcin merged commit 92d5807 into ray-project:master Aug 13, 2024
5 checks passed
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Aug 14, 2024
)

Split out `TestHTTPProxy` and `TestgRPCProxy` into a unit test file.

Signed-off-by: Cindy Zhang <[email protected]>
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Aug 15, 2024
)

Split out `TestHTTPProxy` and `TestgRPCProxy` into a unit test file.

Signed-off-by: Cindy Zhang <[email protected]>
@zcin zcin deleted the proxy-unit-test branch August 21, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants