[Utility] add env_float utility into ray._private.ray_constants
#47117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hongpeng Guo <[email protected]>
hongpeng-guo
changed the title
env_float utility into ray._private.ray_constant
hongpeng-guo
requested review from
justinvyu,
matthewdeng,
raulchen and
woshiyyya
hongpeng-guo
changed the title
env_float utility into ray._private.ray_constantenv_float utility into ray._private.ray_constants
jjyao
approved these changes
Aug 13, 2024
woshiyyya
reviewed
Aug 13, 2024
| @@ -23,6 +23,21 @@ def env_integer(key, default): | |||
| return default | |||
|
|
|||
|
|
|||
| def env_float(key, default): | |||
There was a problem hiding this comment.
QQ: Any use cases where we set float in env_var?
There was a problem hiding this comment.
Good question! In some cases in runtime, it's better to use float numbers for timeout_values, especially when comparing them to real-time (float) values. Reading them as floats makes more sense in those scenarios.
woshiyyya
approved these changes
Aug 13, 2024
|
Add a unit test for this function? |
Also thought about this. But it seems we don't have tests for |
simonsays1980
pushed a commit
to simonsays1980/ray
that referenced
this pull request
Aug 14, 2024
…ay-project#47117) The current codebase includes `env_bool` and `env_integer` functions that directly convert environment variable strings into their respective types. To extend this functionality, we also need an `env_float` function to safely convert strings representing floating-point numbers into the `float` type." Signed-off-by: Hongpeng Guo <[email protected]>
simonsays1980
pushed a commit
to simonsays1980/ray
that referenced
this pull request
Aug 15, 2024
…ay-project#47117) The current codebase includes `env_bool` and `env_integer` functions that directly convert environment variable strings into their respective types. To extend this functionality, we also need an `env_float` function to safely convert strings representing floating-point numbers into the `float` type." Signed-off-by: Hongpeng Guo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The current codebase includes
env_boolandenv_integerfunctions that directly convert environment variable strings into their respective types. To extend this functionality, we also need anenv_floatfunction to safely convert strings representing floating-point numbers into thefloattype."Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.