Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc][ml] add one missing train public API reference + lint checker #47134

Merged
merged 1 commit into from
Aug 19, 2024
Merged

[doc][ml] add one missing train public API reference + lint checker #47134

merged 1 commit into from
Aug 19, 2024

Conversation

can-anyscale
Copy link
Collaborator

@can-anyscale can-anyscale commented Aug 14, 2024 •
edited
Loading

Test:

  • CI
Screenshot 2024-08-14 at 11 15 52 AM

matthewdeng
matthewdeng reviewed Aug 14, 2024
View reviewed changes
doc/source/train/api/api.rst Outdated Show resolved Hide resolved
doc/source/train/api/api.rst
:template: autosummary/class_without_autosummary.rst
:toctree: doc/

~train.error.SessionMisuseError
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move ~train.base_trainer.TrainingFailedError from the section below into this one as well?

doc/source/train/api/api.rst
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justinvyu PTAL!

@can-anyscale can-anyscale force-pushed the can-dml01 branch 2 times, most recently from 93bbfe9 to 255e06b Compare August 14, 2024 18:43
@can-anyscale can-anyscale requested a review from a team as a code owner August 14, 2024 18:43
@can-anyscale can-anyscale changed the title [doc][ml] add one missing train public API reference [doc][ml] add one missing train public API reference + lint checker Aug 14, 2024
justinvyu
justinvyu approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@justinvyu justinvyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@justinvyu justinvyu enabled auto-merge (squash) August 19, 2024 18:55
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Aug 19, 2024
@justinvyu justinvyu merged commit cd9dae2 into master Aug 19, 2024
7 checks passed
@justinvyu justinvyu deleted the can-dml01 branch August 19, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewdeng matthewdeng matthewdeng left review comments

@aslonnie aslonnie aslonnie approved these changes

@justinvyu justinvyu justinvyu approved these changes

@hongpeng-guo hongpeng-guo Awaiting requested review from hongpeng-guo hongpeng-guo is a code owner

@raulchen raulchen Awaiting requested review from raulchen raulchen is a code owner

@woshiyyya woshiyyya Awaiting requested review from woshiyyya woshiyyya is a code owner

Assignees

@justinvyu justinvyu

@matthewdeng matthewdeng

Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@can-anyscale @justinvyu @matthewdeng @aslonnie