Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Add docstring to explain Dataset.deserialize_lineage #47203

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

c21
Copy link
Contributor

@c21 c21 commented Aug 19, 2024

Why are these changes needed?

Users had questions about how the serialization and deserialization works under the hood for Dataset. This doc adds simple explanation that the pickle is used to do that.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@c21 c21 added the go add ONLY when ready to merge, run all tests label Aug 19, 2024
python/ray/data/dataset.py Outdated Show resolved Hide resolved
Co-authored-by: Scott Lee <[email protected]>
Signed-off-by: Cheng Su <[email protected]>
@c21 c21 merged commit c01d524 into ray-project:master Aug 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants