[core] push down GetAllNodeInfo and GetAllWorkerInfo filters to GCS. #47213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruiyang Wang <[email protected]>
rynewang
requested review from
a team,
ericl,
pcmoritz and
raulchen
as code owners
|
@rkooo567 could you review this one? |
Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: Ruiyang Wang <[email protected]>
rynewang
changed the title
Signed-off-by: Ruiyang Wang <[email protected]>
rkooo567
approved these changes
Aug 20, 2024
| @@ -341,7 +340,7 @@ async def list_nodes(self, *, option: ListApiOptions) -> ListApiResponse: | |||
| result = list(islice(result, option.limit)) | |||
| return ListApiResponse( | |||
| result=result, | |||
| total=total_nodes, | |||
| total=reply.total, | |||
There was a problem hiding this comment.
QQ: this includes filtered numbers too. right?
There was a problem hiding this comment.
| req_filters = GetAllWorkerInfoRequest.Filters() | ||
| for filter in filters: | ||
| key, predicate, value = filter | ||
| # Special treatments for the Ray Debugger. |
There was a problem hiding this comment.
can you add an unit test?
There was a problem hiding this comment.
Unit test already exists at
ray/python/ray/tests/test_worker_state.py
Line 21 in fc17ff4
| ): | ||
| req_filters.exist_paused_threads = True | ||
| continue | ||
| if key == "is_alive" and predicate == "=" and value == "True": |
There was a problem hiding this comment.
can value be something like 'true' btw? (not 'True')
There was a problem hiding this comment.
updated. now it supports True, true, 1.
Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: Ruiyang Wang <[email protected]>
alexeykudinkin
requested changes
Aug 20, 2024
2 tasks
alexeykudinkin
approved these changes
Aug 21, 2024
Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: Ruiyang Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetAllNodeInfo filters supported: node_id, state, node_name.
GetAllWorkerInfo filters supported: (num_paused_threads != 0), (is_alive == True).
Note that GetAllWorkerInfo filters are used by the Ray Debugger.