Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] [Release Test] Add AWS ACCESS_DENIED as retryable exception for multi-node Data+Train benchmarks #47232

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

scottjlee
Copy link
Contributor

@scottjlee scottjlee commented Aug 20, 2024

Why are these changes needed?

For release tests like read_images_train_1_gpu_5_cpu, read_images_train_4_gpu, read_images_train_16_gpu, and their variants, we observe AWS ACCESS_DENIED errors somewhat consistently, but not every time. By default, we do not retry on ACCESS_DENIED because ACCESS_DENIED can be raised in multiple situations, and does not necessarily stem from authentication failures; hence we cannot distinguish auth errors from other unrelated transient errors. See #47230 for more details on the underlying issue.

For the purpose of this release test, we don't foresee authentication issues, so we add ACCESS_DENIED as a retryable exception type, to avoid failures for transient errors.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy

Signed-off-by: Scott Lee <[email protected]>
@scottjlee scottjlee marked this pull request as ready for review August 20, 2024 23:55
@scottjlee scottjlee added the go add ONLY when ready to merge, run all tests label Aug 20, 2024
Signed-off-by: Scott Lee <[email protected]>
@scottjlee scottjlee merged commit 2063395 into ray-project:master Aug 21, 2024
5 checks passed
aslonnie added a commit that referenced this pull request Aug 21, 2024
…r multi-node Data+Train benchmarks

cherrypick #47232

Signed-off-by: Lonnie Liu <[email protected]>
aslonnie added a commit that referenced this pull request Aug 21, 2024
…r multi-node Data+Train benchmarks (#47255)

cherrypick #47232

Signed-off-by: Lonnie Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants