[train] update TORCH_NCCL_ASYNC_ERROR_HANDLING env var #47292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Deng <[email protected]>
Signed-off-by: Matthew Deng <[email protected]>
justinvyu
approved these changes
Aug 23, 2024
| if backend == "nccl": | ||
| # See https://github.com/pytorch/pytorch/blob/c263bd43e8e8502d4726643bc6fd046f0130ac0e/torch/distributed/distributed_c10d.py#L803-L823 # noqa: E501 | ||
| # We do not use TORCH_NCCL_BLOCKING_WAIT due to performance overhead. | ||
| if Version(torch.__version__) < Version("2.2.0"): |
There was a problem hiding this comment.
how'd you find this version in the end?
There was a problem hiding this comment.
Oops I haven't updated the PR description, but it was added in pytorch/pytorch@8f8722e!
Co-authored-by: Justin Yu <[email protected]> Signed-off-by: matthewdeng <[email protected]>
matthewdeng
requested review from
hongpeng-guo,
raulchen and
woshiyyya
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Fixes this warning:
This environment variable was changed in
torch 2.2.0: pytorch/pytorch@8f8722e.More details about this environment variable can be found here: https://github.com/pytorch/pytorch/blob/dc8bb2636c5412c68e72dc6e33a6589683d8fd12/docs/source/torch_nccl_environment_variables.rst.
Related issue number
Closes #47286
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.